Skip to content

Use system cursors instead of embedded raster images where possible #7838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rubiefawn
Copy link
Contributor

This PR changes several views to utilize the system's cursors where possible instead of setting the cursor to raster images.

Marking this as draft, since this currently only modifies uses of hand.png. There are other cursors that can also be updated in this same way.

@Rossmaxx
Copy link
Contributor

Rossmaxx commented Apr 8, 2025

While we are at it, would make sense to remove the hand.png file, and other cursor files as they are being removed.

@rubiefawn
Copy link
Contributor Author

That is the intent yes

@AW1534
Copy link
Member

AW1534 commented Apr 9, 2025

On my system (KDE Wayland), there is no change. It still uses the wrong hand cursor
Scratch that, it works, but you forgot to change it for the clips (e.g sample clips, MIDI clips, B&B clips)

There are 2 mentions of the "hand" sprite in ClipView.cpp

@rubiefawn
Copy link
Contributor Author

you forgot to change it for the clips

I didn't forget, this PR is marked as a draft for a reason. This PR is larger in scope than just hand.png, and the clips cursors are part of that scope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants