Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a slider to the setup dialog/settings window, allowing users to set the
QT_SCALE_FACTOR
from within LMMS. This is done by callingqputenv
to set the environment variable before theQApplication
starts.Demo
lmms_ui_scale_factor_demo.mp4
However, there is a problem; I assumed that we wanted to store the scale factor in the config file, but you cannot load the config file until the qApp starts. But you have to set the scale factor env var before the qApp starts for it to take effect. So, I decided to add a temproary qApp object which would be used to load the settings, then set the env var, delete the qApp, and continue with the startup (kind of based on https://stackoverflow.com/a/55408574).
Does anyone have any better idea on how this could be done? Should we even be using the scale factor environment variable for ui scaling?