Skip to content

Make playhead red when recording #7847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

AW1534
Copy link
Member

@AW1534 AW1534 commented Apr 15, 2025

video.mp4

@regulus79
Copy link
Contributor

I briefly tested this, and I am able to get into a state where the step recorder playhead is detached from the normal playhead. Then again, this might be how it is on master also.

image

Also, the step recorder color seems to be a bit more pink/orange than the recording playhead?

(And I tested, the themeable recording line color does seem to work! I'm able to change it's color via css in my purple theme)

@AW1534
Copy link
Member Author

AW1534 commented Apr 19, 2025

I briefly tested this, and I am able to get into a state where the step recorder playhead is detached from the normal playhead. Then again, this might be how it is on master also.

Yeah It's the same as master. Maybe I should hide the playhead while step recording?

Also, the step recorder color seems to be a bit more pink/orange than the recording playhead?

Yeah I noticed that. I got the color from the step recorder button (which is just (255, 0, 0). Which colour do you prefer? I'll make sure they match up.

@regulus79
Copy link
Contributor

Yeah I noticed that. I got the color from the step recorder button (which is just (255, 0, 0). Which colour do you prefer? I'll make sure they match up.

To be honest, the current red color of the recording line sort of feels really dark, but maybe that's just because I'm not used to it. Maybe someone else can give their opinion too?

Maybe I should hide the playhead while step recording?

Well, you are able to use the playhead to kind of "preview" the notes you've added so far, so I think it makes sense to keep it there. Actually now that I think about it, the recording done in the step recorder is with it's own playhead, not with the piano roll's playhead, so it might even be okay to keep the normal playhead white?

@AW1534
Copy link
Member Author

AW1534 commented Apr 19, 2025

To be honest, the current red color of the recording line sort of feels really dark, but maybe that's just because I'm not used to it. Maybe someone else can give their opinion too?

@bratpeki what do you think about the colour of the playhead? maybe we use one of the reds mentioned in #5166

#fe6b6f
#ff4757
#ee043b

One thing's for sure is we should agree on a red to use for recording and stick to it across the board.

Well, you are able to use the playhead to kind of "preview" the notes you've added so far, so I think it makes sense to keep it there. Actually now that I think about it, the recording done in the step recorder is with it's own playhead, not with the piano roll's playhead, so it might even be okay to keep the normal playhead white?

Yeah, I think you're right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants