SlicerT, clear all notes

[bratpeki]

Adds a button that deletes all cuts made in a SlicerT instance.

2025-04-16.18-07-30.mp4

[bratpeki]

Trying to center the buttons right now, that's proving a bit difficult.
Current attempt looks like this:

I'll have to check the bounding box size, since I don't know if some row of pixels belongs to that box or not.
For now, I have this approach I won't be pushing; gotta do more digging:

-       m_syncToggle->move((width() - 100), m_y1 + 5);
-       m_clearButton->move((width() - 100), m_y1 + 30);
+       m_syncToggle->move((width() - 100), m_y1 - 7);
+       m_clearButton->move((width() - 100), m_y1 + 18);

[bratpeki]

I think this looks pretty good:

I worked off the logic of original offset of the first button + relative offset the second button begins at - half of the offset of the second button. This gave me the numbers:

m_syncToggle->move((width() - 100),  m_y1 + 5      - 11);
m_clearButton->move((width() - 100), m_y1 + 5 + 22 - 11);

which is just:

m_syncToggle->move((width() - 100), m_y1 - 6);
m_clearButton->move((width() - 100), m_y1 + 16);

Literally just magic numbers! 🤣

---

Pushing that for now, I might find some better numbers.

[bratpeki]

Go magic numbers, I guess! 😆

[bratpeki]

Keep in mind:

• there are still tr missing comments
• the button pixmap could be better (say, by having an eraser icon next to "CLEAR")
• clearSlices is better than clearAll, I am planning to rename the method
• the spacing between the buttons could be bigger

[AW1534]

It freezes upon clicking the MIDI button after clearing all notes. this is consistently reproducible.

video.mp4

[AW1534]

video.mp4

This fixes it

[regulus79]

Do we normally use camelCase for image file names?

[AW1534]

nope, usually snake_case

[bratpeki]

Will adress both in the next commit 🫡

[bratpeki]

Fixed! The changes include:

• Added a push_back for both 0 and 1
• Changed the new image files' names to use snake case
• Removed the m_clearAll variable from the SlicerT class, since that doesn't have to be saved to a project

[AW1534]

I think you forgot to push 😆

[bratpeki]

Doing final checks and pushing in a minute, I promise! 🤣

[bratpeki]

Please note that I'm still using a series of pluses and minuses to calculate buttons positions. I'd like to shorten that down before the merge. If this looks good, I'll shorten it right now:

[AW1534]

Please note that I'm still using a series of pluses and minuses to calculate buttons positions. I'd like to shorten that down before the merge. If this looks good, I'll shorten it right now:

Looks good to me. You should add a comment that directs to this PR, which explains the mysterious values.

[bratpeki]

@AW1534 Not a pushed change, just thinking out loud:

- brush.drawText(s_x4 - 8, y1_text, s_textBoxWidth, s_textBoxHeight, Qt::AlignCenter, tr("Midi"));
+ brush.drawText(s_x4 - 8, y1_text, s_textBoxWidth, s_textBoxHeight, Qt::AlignCenter, tr("MIDI")); // tr(...)? I'm pretty sure it's "MIDI" in every language lol

[AW1534]

@AW1534 Not a pushed change, just thinking out loud:

- brush.drawText(s_x4 - 8, y1_text, s_textBoxWidth, s_textBoxHeight, Qt::AlignCenter, tr("Midi"));
+ brush.drawText(s_x4 - 8, y1_text, s_textBoxWidth, s_textBoxHeight, Qt::AlignCenter, tr("MIDI")); // tr(...)? I'm pretty sure it's "MIDI" in every language lol

Yeah there's no need to translate MIDI.