-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
implementing actions #7859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
szeli1
wants to merge
134
commits into
LMMS:master
Choose a base branch
from
szeli1:WHAI_implementing_actions
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
implementing actions #7859
+1,994
−309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
197601a
to
6c65c8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR in a series of PRs in the goal of achieving #7734
Roadmap:

This PR implements Actions, a layer between the user and the GUI. Every user interaction will be routed through actions. Actions will provide a better way of journalling and overall clarity in code. The end goal is replacing core JO and Project Journal without saving to xml text. This way loading in data is faster and takes up less space in memory.
This PR replaces the old shortcut system struct with an
ActionStruct
. Action structs hold all the data needed to construct an action, and some additional data that decides how actions are called. A gui action input / output class is added that stores lmms specific datatypes. A gui action class is also implemented, it will be derived from theQUndoCommand
class in the future.QActions
are used as function pointers for theseGuiActions
. Classes that inheritInteractiveModelView
need to implement 2 virtual functions:How to test: test if the features in #7488 work (this PR is more like a refactor, so the 7488 features should work)
Everything should work the same way it worked in #7488
This PR branches off off #7488, so #7488 should be merged before this