Piano Roll Detuning - QoL Port #8187
Draft
+79
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Right click and right click dragging on the first Node will now reset it to 0.0f. -Alt Left Click will now move OutValue on nodes after the first one if a node at the quantized time exists. --This is still a bit finnicky. Should I make it search for previous nodes?
-Pitch bend editing now previews what the note sounds like. -Signal OutValue nodes as smaller circles. (Displays as square at current parameters.) -Draw end of automation hooks for better visibility.
This may have performance implications. 2 Commits from Personal squashed together: Render note slide curves in piano roll. -Draw a line for every tick. Fix display of CubicHermite discrete jumps -Hide the discrete jump handles in CubicHermite mode unless detuning mode is active.
-Fix compiling. -Allow moving to and from first node again. Right click to reset the first node is currently wonky.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP port of regulus79#3 to the merged master #7759 for some QoL changes to the Piano Roll Detuning:
-Better visual feedback to detuning curves
--Hooks to signify the end of a detuning curve
--outValue changes having small dots in detuning mode
--CubicHermite curves actually displaying properly
-Better handling of the first node
--Right click to reset to default tuning
NOTE: This is currently wonky in how it selects the node, and basically requires you to zoom in.
--Allow dragging over again
-Allow Alt+Drag to allow outValue editing
-Auditory feedback when detuning notes
#8104 will break the outValue editing functionality.
I will update this while I work through the code changes.