Skip to content

Fix velocity/panning change affecting unselected notes #8201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yohannd1 wants to merge 1 commit into
base: master
Choose a base branch
from
+17 −1
Open

Fix velocity/panning change affecting unselected notes #8201

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion src/gui/editors/PianoRoll.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4055,15 +4055,31 @@ void PianoRoll::wheelEvent(QWheelEvent * we )

// When alt is pressed we only edit the note under the cursor
bool altPressed = we->modifiers() & Qt::AltModifier;

// go through notes to figure out which one we want to change
NoteVector nv;
bool isSelection = false;
for ( Note * i : m_midiClip->notes() )
{
if( i->withinRange( ticks_start, ticks_end ) || ( i->selected() && !altPressed ) )
if (i->selected() && !altPressed) // found a selected note
{
if (!isSelection)
{
// drop other notes if we are realizing this is a selection now
isSelection = true;
nv.clear();
}

nv.push_back(i);
}

// not on selection - just push back the note if it is within range
if (!isSelection && i->withinRange(ticks_start, ticks_end))
{
nv.push_back(i);
}
}

if( nv.size() > 0 )
{
const int step = (we->angleDelta().y() > 0 ? 1 : -1) * (we->inverted() ? -1 : 1);
Expand Down
Loading