-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
"Universal" workspace panning #8203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
szeli1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My concern with this PR is that it looks like to me that other "ctrl + alt" mouse shortcuts may not work because of the event filter. I did not test this PR.
Here is some code that may be effected:
AutomationEditor:
}
else if( we->modifiers() & Qt::ControlModifier && we->modifiers() & Qt::AltModifier )
{ClipView:
bool ClipView::unquantizedModHeld( QMouseEvent * me )
{
return me->modifiers() & Qt::ControlModifier || me->modifiers() & Qt::AltModifier;
}PianoRoll:
void PianoRoll::dragNotes(int x, int y, bool alt, bool shift, bool ctrl)|
|
||
| #include <QApplication> | ||
| #include <QCloseEvent> | ||
| #include <QDebug> // TODO: remove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| #include <QDebug> // TODO: remove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will remove this right before I remove the draft state. I'm using it for debugging some things :)
Co-authored-by: szeli1 <[email protected]>
|
Changed the keybinding to Also a note to self: adding the keybinding handling on the event filter is sadly necessary, as when it is pressed I have to prevent it from being forwarded to other elements. I tried implementing it with key{Press,Release}Event and it was a mess. |
If I remember correctly, there are other options like implementing it in |
This PR adds the ability to pan through the workspace without having to click on the background. At the moment, the trigger I have used for this is the key combo Ctrl+Alt, which might not be ideal, but it was the most unique modifier combination I could think of.
vid.mp4
Feedback is very welcome! I want to see if other people would have their workflow improved by being able to do this. I believe mine will.
Progress:
Ctrl+Alt->Alt+S