Apply name filter if export file lacks extension #8212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When exporting the project, if no extension is specified in the filename, LMMS defaults to using
.wav. It would be much better for it to use the selected name filter's extension as a fallback if no extension is in the filename. This PR does exactly that. I also refactored the stuff since it was confusing (it intermingled multi export and non multi export code together).Note: There is another slightly related bug, where if the file format combobox changes to a new format and the filename already has an extension, the extension associated with the selected file format is appended to it instead of being changed accordingly. This should be looked into and fixed later.
Fixes #8205.