Fix: Escape HTML in effect author names to show email addresses#8351
Open
beingrahull wants to merge 1 commit intoLMMS:masterfrom
Open
Fix: Escape HTML in effect author names to show email addresses#8351beingrahull wants to merge 1 commit intoLMMS:masterfrom
beingrahull wants to merge 1 commit intoLMMS:masterfrom
Conversation
Contributor
|
Isn't this already covered by #7975? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed a bug where plugin author email addresses (and any strings containing < or >) were hidden in the Effect Browser. This occurred because the UI treats the author string as Rich Text, causing the renderer to interpret email brackets as malformed HTML tags.
Changes
Applied toHtmlEscaped() to the descriptor.author string in the plugin browser UI.
This ensures special characters are rendered as literal text instead of HTML tags.