Skip to content

Conversation

@lohedges
Copy link

@lohedges lohedges commented Sep 12, 2025

This PR closes #8 by updating Scan.xs to remove the use of unnamed arguments, which is a requirement of xsubpp in Perl 5.42. I think this change is backwards compatible. If not, then I can add some logic to detect the Perl version and set an appropriate signature.

(Thanks @baslking and @Amphitryon from the AUR lyrionmusicserver package here for the fix.)

Cheers.

@michaelherger
Copy link
Member

@ralph-irving do you see a problem with backwards compatibility with this?

@michaelherger
Copy link
Member

Now how would I run the "Build" workflow on this PR?...

@lohedges
Copy link
Author

lohedges commented Sep 12, 2025

I'll rebase against master and push.

@michaelherger
Copy link
Member

Thanks, that did the trick. Does build just fine on Perl 5.32. I doubt we'll build anything older than that going forward.

@lohedges
Copy link
Author

Brilliant, thanks for adding the CI 👍

@lohedges lohedges changed the title Fix isssue #8 Fix issue #8 Sep 12, 2025
@ralph-irving
Copy link

@ralph-irving do you see a problem with backwards compatibility with this?

@michaelherger No I don't think so. I applied PR#9 to a local system running perl 5.28 and it built/ran without issue.
I agree that we unlikely need to support older perl versions at this point. 5.28 was released in 2018 and it's okay, should be good enough.

I'll merge this as well as PR#6 and create a 1.11 release.

@ralph-irving ralph-irving merged commit 1fa3847 into LMS-Community:master Sep 16, 2025
2 checks passed
@lohedges lohedges deleted the fix_8 branch September 16, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build issue with Perl 5.42 on Arch Linux

3 participants