Skip to content

extend command flavor_price_list #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 8, 2025
Merged

extend command flavor_price_list #442

merged 10 commits into from
Oct 8, 2025

Conversation

@fredberto
Copy link
Contributor

@fredberto fredberto commented Sep 7, 2025 •
edited by gierens
Loading

Fixes #449 and fixes #417

@gierens gierens added enhancement New feature or request rust Pull requests that update Rust code api src test feat labels Sep 9, 2025
gierens
gierens requested changes Sep 9, 2025
View reviewed changes
Copy link
Member

@gierens gierens left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly fine, thanks! See comments below.

Haven't commented on the UserClass stuff again, see review in #438 for that.

@fredberto fredberto force-pushed the flavor-price-list branch 3 times, most recently from 1323852 to 89c888d Compare September 25, 2025 12:05
@fredberto fredberto force-pushed the flavor-price-list branch 7 times, most recently from 0e19120 to bb62672 Compare September 29, 2025 15:27
@gierens gierens force-pushed the flavor-price-list branch from bb62672 to 5a268fa Compare October 7, 2025 18:27
gierens added 7 commits October 8, 2025 00:35
@gierens
feat(api/database/pricing): add select_flavor_prices_for_userclass_an…
b8905e4 
…d_period_from_db

Signed-off-by: Sandro-Alessio Gierens <[email protected]>
@gierens
chore(sqlx): update offline query data
950791f 
Signed-off-by: Sandro-Alessio Gierens <[email protected]>
@gierens
fix(api/pricing): allow both filters on flavor-price list
401be7a 
Signed-off-by: Sandro-Alessio Gierens <[email protected]>
@gierens
feat(cli/pricing): make --current an actual flag on flavor-price list
0dfb549 
Signed-off-by: Sandro-Alessio Gierens <[email protected]>
@gierens
test(pricing/flavor_price): e2e_lib_flavor_price_list_current and add…
53b1388 
… e2e_lib_flavor_price_list_current_and_user_class

Signed-off-by: Sandro-Alessio Gierens <[email protected]>
@gierens
fix(api/database/pricing): filter out outdated prices in select_flavo…
1147aaf 
…r_prices_for_*period_from_db functions

Signed-off-by: Sandro-Alessio Gierens <[email protected]>
@gierens
chore(sqlx): update offline query data
94c50fa 
Signed-off-by: Sandro-Alessio Gierens <[email protected]>
@gierens
Copy link
Member

gierens commented Oct 8, 2025 •
edited
Loading

Alright, so this looks good! Thanks! I only made some minor fixes and a couple of additions:

  • I made -c/--current bool again, this shouldn't be an Option as it makes the interface messy.
  • I also adjusted the endpoint to handle the case that both the current and user class filter are set by adding a new database call for this and also a new test.
  • And finally, I adjusted both database calls to correctly filter our outdated prices and adjusted tests accordingly. This fixes Bug in Flavor Price for Period Selection #449 and also fixes Occasional Server Cost Misses #417.

@gierens gierens merged commit e170ec6 into LRZ-BADW:main Oct 8, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gierens gierens gierens approved these changes

Assignees

No one assigned

Labels

api enhancement New feature or request feat rust Pull requests that update Rust code src test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug in Flavor Price for Period Selection Occasional Server Cost Misses

2 participants

@fredberto @gierens