set global for top level cli arguments #443
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gierens
added
enhancement
gierens
requested changes
Sep 9, 2025
There was a problem hiding this comment.
Yeah, that's good in general there is a catch, though ... Clap does not check at compile time for duplication across different namespaces ... while -R and -T are unique so far, -I and -f are not. Both are also used for the server-state modify command. ... I'm not actually sure how Clap handles such cases if at all. We should probably rename some of the short flags to avoid duplication. Since server-state modify is a very rare command, changing its flags has the least impact.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #112