Source refactor#314
Merged
Merged
Conversation
…into source_refactor merged to remote
sibirrer
requested changes
Apr 5, 2025
sibirrer
left a comment
sibirrer
left a comment
Contributor
There was a problem hiding this comment.
Thank you very much @nkhadka21 ! This looks much better. I have quite a few comments that hopefully make the structure more explicit and structured.
…into source_refactor merged to remote
sibirrer
approved these changes
Apr 9, 2025
sibirrer
left a comment
sibirrer
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thank you very much!
Can you please open issues for the features that we might change in the future?
Collaborator
Author
Thanks Simon! Yes, I will open issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors Source class!