EPL Documentation / Edge cases#387
Open
smericks wants to merge 2 commits into
Open
Conversation
Contributor
smericks
commented
Nov 26, 2025
- remove stellar_mass as a required parameter in both epl and epl_sersic docstrings
- change angular_size to an optional parameter in the epl docstring (see test_epl.py, angular_size is never used)
- add center_x, center_y as optional parameters in both epl and epl_sersic docstrings
- currently, a user is allowed to provide both a v_disp and a theta_E. But, there is no guarantee that the two quantities are consistent, especially if the cosmology changes. I introduce a check for this edge case, and raise an error if both are provided. There is no way to check if the two quantities are consistent without assuming a cosmology model.
- I also check if a user tries to compute theta_E without providing a lens_cosmo, raising a useful error message (not sure the convention for this)
Contributor
Author
|
Seems like not allowing a user to provide both v_disp and a theta_E breaks an existing test cases in tests/test_Lenses/test_lens.py, because at line 537, both a v_disp and theta_E are provided when making a mock lens for a test case. AND note to self for next commit: angular_size is in arcseconds, not radians... (see theta_E_from_vel_disp_epl()) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.