notebook to generate visit images faster with precomputed backgrounds#432
Merged
sibirrer merged 11 commits intoJun 12, 2026
Merged
Conversation
…s and saved psfs for Roman
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #432 +/- ##
==========================================
+ Coverage 98.65% 98.66% +0.01%
==========================================
Files 106 106
Lines 8320 8340 +20
==========================================
+ Hits 8208 8229 +21
+ Misses 112 111 -1
🚀 New features to boost your workflow:
|
sibirrer
requested changes
Jun 12, 2026
sibirrer
left a comment
sibirrer
left a comment
Contributor
There was a problem hiding this comment.
Thank you @timedilatesme! I have one minor request
| dec=None, | ||
| date=datetime.datetime(year=2027, month=7, day=7, hour=0, minute=0, second=0), | ||
| psf_directory=None, | ||
| precomputed_background=None, |
Contributor
There was a problem hiding this comment.
can you add a doc string for this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved some notebooks around and added a new notebook to visualize visit images from both LSST and Roman with micorlensing alongwith precomputing backgrounds and reusing saved PSFs