Stars fix with regular inv #53
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
There's still some work needed to make it fully compatible with the calculation of the noise bias in the presence of stars but this branch is working with the SNR calculations. |
Contributor
|
We can probably close this PR right @fjaviersanchez ? |
Collaborator
Author
|
I believe so! |
Collaborator
Author
|
actually, I think that we should merge stuff from here to deal with stars. Let me please check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the alternative way to treat stars in the code. Note that we shouldn't merge #52 and this one at the same time. It's probably good to choose one or the other.