-
Notifications
You must be signed in to change notification settings - Fork 8
Firecrown app #583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firecrown app #583
Conversation
|
@vitenti it would be amazing if we could provide a likelihood experiment (in .py for example) and then also be able to build the config files for numcosmo/cosmosis/cobaya... is this a possibility ? |
|
Two other suggestions for the examples:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #583 +/- ##
=========================================
Coverage 100.0% 100.0%
=========================================
Files 122 150 +28
Lines 6964 8782 +1818
Branches 819 1012 +193
=========================================
+ Hits 6964 8782 +1818
🚀 New features to boost your workflow:
|
Thanks for the suggestions, these were just implemented. |
Yes, this PR introduces all the necessary infrastructure for that. However, since this one is already big, I think it is better to leave this feature to a next PR. |
Nicer outputs.
More tests for _view and _transform.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 88 out of 100 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description
Introduce Firecrown CLI Application
This PR introduces a new command-line interface (CLI) for Firecrown that simplifies the creation and management of cosmological analysis examples. The
firecrowncommand provides a unified interface to generate complete analysis pipelines with data files and framework-specific configurations.Key Features
Example Generator System
cosmic_shear: Weak lensing cosmic shear with synthetic galaxy datasn_srd: Supernova SRD analysis with LSST DESC synthetic datades_y1_3x2pt: DES Y1 3x2pt analysis (cosmic shear + galaxy-galaxy lensing + galaxy clustering)Multiple Factory Implementations
The DES Y1 3x2pt example supports multiple factory types:
standard,pt(perturbation theory),tatt(TATT IA model),hmia(halo model IA),pk_modifier(baryonic effects)yaml_default,yaml_pure_ccl,yaml_mu_sigma(modified gravity)Flexible Configuration
Architecture
firecrown/app/analysis/) and examples (firecrown/app/examples/)Usage Example
Implementation Highlights
This CLI makes it significantly easier for users to get started with Firecrown and provides a standardized way to generate analysis configurations across different statistical frameworks.
Type of change
Please delete the bullet items below that do not apply to this pull request.
Checklist:
The following checklist will make sure that you are following the code style and
guidelines of the project as described in the
contributing page.
bash pre-commit-checkand fixed any issues