Skip to content

Conversation

@vitenti
Copy link
Collaborator

@vitenti vitenti commented Dec 11, 2025

Description

Updated templates to new tracer ordering.

Type of change

  • Refactoring

Checklist:

The following checklist will make sure that you are following the code style and
guidelines of the project as described in the
contributing page.

  • I have run bash pre-commit-check and fixed any issues
  • I have added tests that prove my fix is effective or that my feature works
  • I have made corresponding changes to the documentation
  • I have 100% test coverage for my changes (please check this after the CI system has verified the coverage)

Updated templates to new tracer ordering.
@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.0%. Comparing base (1e4ce05) to head (9cf3757).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #597   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         150      150           
  Lines        8782     8787    +5     
  Branches     1012     1012           
=======================================
+ Hits         8782     8787    +5     
Files with missing lines Coverage Δ
...irecrown/app/examples/_des_y1_3x2pt_pt_template.py 100.0% <ø> (ø)
firecrown/app/examples/_des_y1_3x2pt_template.py 100.0% <ø> (ø)
firecrown/app/sacc/_load.py 100.0% <100.0%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates tracer ordering conventions for galaxy_shearDensity_xi_t two-point statistics and adds warning suppression for loading old SACC format files. The key change standardizes the parameter order so that WeakLensing sources come first (source0) and NumberCounts sources come second (source1) in cross-correlation statistics.

  • Standardizes tracer ordering for galaxy-shear density correlations across templates and tests
  • Adds warning/output suppression when loading SACC files to handle old format files cleanly
  • Updates test expectations to handle new warning messages from inverse covariance computations
  • Refactors fixture naming to follow pytest conventions

Reviewed changes

Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/test_pt_systematics.py Updates TwoPoint instantiation order and TracerNames order for galaxy_shearDensity_xi_t statistics to put WeakLensing first
tests/likelihood/gauss_family/test_const_gaussianPM.py Updates tracer ordering, adds pytest.warns contexts for new inverse covariance warnings, renames fixture to follow conventions, adds pylint directive
firecrown/app/sacc/_load.py Adds contextlib redirects and warning suppression when loading SACC files to handle old format files
firecrown/app/examples/_des_y1_3x2pt_template.py Updates tracer ordering in TwoPoint instantiation to put WeakLensing source first
firecrown/app/examples/_des_y1_3x2pt_pt_template.py Updates tracer ordering in TwoPoint instantiation to put WeakLensing source first

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@marcpaterno marcpaterno merged commit b1aa3d5 into master Dec 11, 2025
13 checks passed
@marcpaterno marcpaterno deleted the tracer_order_fix branch December 11, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants