-
Notifications
You must be signed in to change notification settings - Fork 8
Fixing ordering and old sacc format. #597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated templates to new tracer ordering.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #597 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 150 150
Lines 8782 8787 +5
Branches 1012 1012
=======================================
+ Hits 8782 8787 +5
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates tracer ordering conventions for galaxy_shearDensity_xi_t two-point statistics and adds warning suppression for loading old SACC format files. The key change standardizes the parameter order so that WeakLensing sources come first (source0) and NumberCounts sources come second (source1) in cross-correlation statistics.
- Standardizes tracer ordering for galaxy-shear density correlations across templates and tests
- Adds warning/output suppression when loading SACC files to handle old format files cleanly
- Updates test expectations to handle new warning messages from inverse covariance computations
- Refactors fixture naming to follow pytest conventions
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
tests/test_pt_systematics.py |
Updates TwoPoint instantiation order and TracerNames order for galaxy_shearDensity_xi_t statistics to put WeakLensing first |
tests/likelihood/gauss_family/test_const_gaussianPM.py |
Updates tracer ordering, adds pytest.warns contexts for new inverse covariance warnings, renames fixture to follow conventions, adds pylint directive |
firecrown/app/sacc/_load.py |
Adds contextlib redirects and warning suppression when loading SACC files to handle old format files |
firecrown/app/examples/_des_y1_3x2pt_template.py |
Updates tracer ordering in TwoPoint instantiation to put WeakLensing source first |
firecrown/app/examples/_des_y1_3x2pt_pt_template.py |
Updates tracer ordering in TwoPoint instantiation to put WeakLensing source first |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Description
Updated templates to new tracer ordering.
Type of change
Checklist:
The following checklist will make sure that you are following the code style and
guidelines of the project as described in the
contributing page.
bash pre-commit-checkand fixed any issues