-
Notifications
You must be signed in to change notification settings - Fork 2
Tqz/attach useful cols #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ztq1996
wants to merge
11
commits into
main
Choose a base branch
from
tqz/attach_useful_cols
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #186 +/- ##
==========================================
+ Coverage 98.99% 99.01% +0.02%
==========================================
Files 46 46
Lines 3085 3153 +68
==========================================
+ Hits 3054 3122 +68
Misses 31 31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8ca1ffe
to
84994f5
Compare
84994f5
to
3edb4f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem & Solution Description (including issue #)
Attach object ID and redshift, if available, to the qp output. This is done in _do_chunk_output() , so every method will get it when calling this function. But the trade-off is that the _do_chunk_output() function now requires data, so that needs to be changed in every estimator. If someone has an idea of how to do this without an API-breaking change, that’d be lovely.
A point-to-point evaluator class which compute the point-to-point metrics with binning, meaning you can bin the galaxies by redshift or magnitude, or anything available in the catalog, and get a list of metrics by the binning column.
Code Quality
#pragma: no cover
; in the case of a bugfix, a new test that breaks as a result of the bug has been added