Skip to content

Tqz/attach useful cols #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Tqz/attach useful cols #186

wants to merge 11 commits into from

Conversation

ztq1996
Copy link
Contributor

@ztq1996 ztq1996 commented Apr 8, 2025

Problem & Solution Description (including issue #)

  1. Attach object ID and redshift, if available, to the qp output. This is done in _do_chunk_output() , so every method will get it when calling this function. But the trade-off is that the _do_chunk_output() function now requires data, so that needs to be changed in every estimator. If someone has an idea of how to do this without an API-breaking change, that’d be lovely.

  2. A point-to-point evaluator class which compute the point-to-point metrics with binning, meaning you can bin the galaxies by redshift or magnitude, or anything available in the catalog, and get a list of metrics by the binning column.

Code Quality

  • My code follows the code style of this project
  • I have written unit tests or justified all instances of #pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added
  • My code contains relevant comments and necessary documentation for future maintainers; the change is reflected in applicable demos/tutorials (with output cleared!) and added/updated docstrings use the NumPy docstring format
  • Any breaking changes, described above, are accompanied by backwards compatibility and deprecation warnings

Copy link

codecov bot commented Apr 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.01%. Comparing base (4e0b664) to head (3edb4f7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #186      +/-   ##
==========================================
+ Coverage   98.99%   99.01%   +0.02%     
==========================================
  Files          46       46              
  Lines        3085     3153      +68     
==========================================
+ Hits         3054     3122      +68     
  Misses         31       31              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@eacharles eacharles force-pushed the tqz/attach_useful_cols branch from 8ca1ffe to 84994f5 Compare April 21, 2025 16:43
@eacharles eacharles force-pushed the tqz/attach_useful_cols branch from 84994f5 to 3edb4f7 Compare April 21, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant