Skip to content

DUNE/Hardware/LUCL: Possible buffer overflow #217

@tsmarques

Description

@tsmarques

Hi,

I think this line might cause a buffer overflow?

In the lines above it we check if the data we're trying to write is smaller than 64 bytes

if (data_size > c_data_max)
    throw std::runtime_error("maximum data size exceeded");

but then the total buffer size for the message is only 32

uint8_t msg[32] = {c_sync, (uint8_t)(data_size + 1), cmd};
std::memcpy(msg + 3, data, data_size);

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions