Skip Harfbuzz dependency on glib #3
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
glib is not strictly required by Harfbuzz - if not present, Harfbuzz will use its built-in Unicode character table. LWGJL does not seem to make use of glib, however these bindings do include the glib dependency (given GitHub runners have it installed by default).
The built-in Unicode table was previously included and used over glib anyway, so this change doesn't come with an additional size cost.
This resolves some issues that we have seen with LWJGL's Freetype bindings failing to load on certain systems (particularly, MacOS x86_64) due to missing glib. The error was a bit cryptic, however:
We weren't able to identify exactly what was going wrong with
dlerror()
returningnull
, however, adding an additional call todlerror()
beforedlopen()
revealed this error:This pointed us towards removing the glib dependency, as it seems unneeded for LWJGL's case as far as we could tell.
Thanks!