Skip to content

Feature/1274 keeper key blast radius - #1341

Merged
K1NGD4VID merged 11 commits into
LabsCrypt:mainfrom
meem08:feature/1274-keeper-key-blast-radius
Sep 3, 2026
Merged

Feature/1274 keeper key blast radius#1341
K1NGD4VID merged 11 commits into
LabsCrypt:mainfrom
meem08:feature/1274-keeper-key-blast-radius

Conversation

@meem08

@meem08 meem08 commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Description

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔧 Refactoring (no functional changes)
  • ⚡ Performance improvement
  • 🧪 Test addition or update

Related Issues

Closes #1274

Changes Made

Testing

Test Coverage

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed

Test Steps

Breaking Changes

Breaking Changes:

Migration Guide:

Screenshots/Demo

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Updated Postman/Hoppscotch API collections if routes changed
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published
  • I have checked for breaking changes and documented them if applicable

Additional Notes

@meem08

meem08 commented Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

@blurbeast review and merge

meem08 and others added 7 commits September 1, 2026 10:26
…anch

- Restore ci.yml, package.json, and package-lock.json to match main:
  re-add the changes job and frontend rollup native binding step, drop the
  uncommitted @rollup/rollup-linux-x64-gnu optional dependency, and bring
  the lockfile back in sync so the frontend lint environment matches main.
- Update cancel integration tests to send senderSecret in the request body
  and rewrite the concurrent-cancel test to reflect actual controller
  behavior (each request performs its own on-chain cancel).
- Update cancel controller unit tests for the senderSecret contract and
  replace the obsolete KEEPER_SECRET_KEY-missing case with a
  senderSecret-missing case.

Generated with Codebuff 🤖
Co-Authored-By: Codebuff <noreply@codebuff.com>
…ancel test)

The main merge re-introduced a duplicate mysql2 override that made
package.json invalid JSON, churned package-lock.json, and left a broken
concurrent-cancel block in the integration test (duplicate promise2
declaration and dangling .set chain) that failed to compile.

Restore package.json and package-lock.json to match main and repair the
integration test so the branch diff contains only the keeper-key blast
radius change.

Generated with Codebuff 🤖
Co-Authored-By: Codebuff <noreply@codebuff.com>
@K1NGD4VID
K1NGD4VID merged commit c94107f into LabsCrypt:main Sep 3, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Audit] Privileged keeper key concentrates authority for every state-changing on-chain action with no per-action cryptographic authorization

2 participants