Fix/1221 reset indexer mutex - #1419
Merged
Merged
Conversation
…ge (LabsCrypt#1209) The pollIndexerForWithdraw loop could run for ~63s with no abort mechanism, causing stale fetches and state writes after the user navigated away or switched wallets. - Thread an AbortController through the polling loop via a useRef - Abort on component unmount and wallet/publicKey change via useEffect cleanup - Check signal.aborted before each fetch, state update, and after delay - Add test verifying unmount mid-backoff stops further fetches 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
…LabsCrypt#1221) resetIndexer wrote IndexerState directly via prisma.indexerState.upsert without acquiring SorobanEventWorker's batchMutex. If triggered while a poll batch was in flight, the batch's fetchAndProcessEvents would finish afterwards and overwrite the reset cursor, silently undoing the admin's reset/replay. - Made runExclusive public so the indexer service can acquire the same lock that serialises poll/replay batches - Wrapped resetIndexer's DB write inside runExclusive, ensuring any in-flight poll completes before the reset writes, and no subsequent batch can overwrite it - Added test verifying reset during in-flight poll ends with reset cursor winning 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Related Issues
Closes #1221
Changes Made
Testing
Test Coverage
Test Steps
Breaking Changes
Breaking Changes:
Migration Guide:
Screenshots/Demo
Checklist
Additional Notes