ci: improve CI/CD workflows and infrastructure - #922
Merged
Conversation
- Add frontend test coverage to CI and Codecov (LabsCrypt#897) - Add .dockerignore for backend to reduce build context (LabsCrypt#894) - Add concurrency control to CI workflows (LabsCrypt#892) - Remove duplicate pr-test-gate.yml workflow (LabsCrypt#891)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves four CI/CD and infrastructure issues:
.dockerignorefor backend to exclude unnecessary files from Docker build context.ci.ymlandsecurity.ymlworkflows to cancel superseded runs.pr-test-gate.ymlas it duplicates tests already covered byci.yml.Type of Change
Related Issues
Closes #897
Closes #894
Closes #892
Closes #891
Changes Made
.github/workflows/ci.ymlto runnpm run test:coverageinstead ofnpm testfor frontendfrontendflag.github/codecov.ymlto include frontend project status withtarget: autobackend/.dockerignoreto exclude:node_modules,dist,coverage,.env*,*.log,src/generatedconcurrencyblock to.github/workflows/ci.ymlwithcancel-in-progress: trueconcurrencyblock to.github/workflows/security.ymlwithcancel-in-progress: true${{ github.workflow }}-${{ github.ref }}.github/workflows/pr-test-gate.ymlas it duplicated backend and contracts tests already inci.ymlTesting
Test Coverage
Test Steps
Breaking Changes
None. Branch protection rules should be updated to point to
ci.ymljobs instead ofpr-test-gate.ymlif they were previously configured.Screenshots/Demo
Checklist
Additional Notes
ci.ymljobs instead of the removedpr-test-gate.ymlworkflowautoin Codecov to allow establishing a baseline before setting specific targets