Skip to content

add server #1863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

add server #1863

wants to merge 8 commits into from

Conversation

FreshFoxyHD
Copy link
Contributor

Type of change

  • Add new directory for a server
  • Update directory of a server
  • Remove directory of a server
  • Documentation Update

Checklist

  • I have read the README doc
  • I have compressed the images appropriately (e.g. on https://tinypng.com)
  • I have created the manifest.json with the required values

Further comments

github-actions[bot]
github-actions bot requested changes May 4, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • JSON is invalid! Workflow is not able to check minecraft_servers/voidlounge/manifest.json

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

github-actions[bot]
github-actions bot requested changes May 4, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • JSON is invalid! Workflow is not able to check minecraft_servers/voidlounge/manifest.json

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

github-actions[bot]
github-actions bot requested changes May 4, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • JSON is invalid! Workflow is not able to check minecraft_servers/voidlounge/manifest.json

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 4, 2025

Just as an information:
Your server voidlounge.de could be offline.
In general, we only accept pull requests from servers, that are online and publicly available.
Please change this, otherwise we cannot review your server correctly and have to deny the pull request.

Reference: API URL (https://api.mcstatus.io/v2/status/java/voidlounge.de?query=false)

@github-actions GitHub Actions
Copy link

github-actions bot commented May 4, 2025

Just as an information:

@github-actions GitHub Actions
Copy link

github-actions bot commented May 4, 2025

Just as an information:
Your server voidlounge.de could be offline.
In general, we only accept pull requests from servers, that are online and publicly available.
Please change this, otherwise we cannot review your server correctly and have to deny the pull request.

Reference: API URL (https://api.mcstatus.io/v2/status/java/voidlounge.de?query=false)

@github-actions GitHub Actions
Copy link

github-actions bot commented May 4, 2025

Just as an information:

@github-actions GitHub Actions
Copy link

github-actions bot commented May 4, 2025

Just as an information:
Your server voidlounge.de could be offline.
In general, we only accept pull requests from servers, that are online and publicly available.
Please change this, otherwise we cannot review your server correctly and have to deny the pull request.

Reference: API URL (https://api.mcstatus.io/v2/status/java/voidlounge.de?query=false)

@github-actions GitHub Actions
Copy link

github-actions bot commented May 4, 2025

Just as an information:

DoJapHD
DoJapHD requested changes May 4, 2025
View reviewed changes
minecraft_servers/voidlounge/manifest.json
@@ -0,0 +1,32 @@
{
"server_name": "voidlounge",
"nice_name": "VØłĐ ŁØɄŊƓƐ",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only clear text

minecraft_servers/voidlounge/manifest.json
"de"
],
"social": {
"web": "https://voidlounge.de",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not reachable

minecraft_servers/voidlounge/background.png
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compress image

minecraft_servers/voidlounge/manifest.json
{
"server_name": "voidlounge",
"nice_name": "VØłĐ ŁØɄŊƓƐ",
"direct_ip": "voidlounge.de",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not joinable

@DoJapHD
Copy link
Collaborator

DoJapHD commented May 12, 2025

Inactive PR

@DoJapHD DoJapHD closed this May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] requested changes

@DoJapHD DoJapHD DoJapHD requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FreshFoxyHD @DoJapHD