LibWeb: HMAC and spec fixes #3092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The spec has been fixed since w3c/webcrypto#391.
This assignment was missing from the spec, but has been fixed since w3c/webcrypto#394. Also add relevant WPT tests.
When the default key size was requested it was expressed in bytes (instead of bits) and from the digest size instead of the block size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There where a couple of spec issues in the way of some WPT tests. I got those merged in the spec (w3c/webcrypto#394 and w3c/webcrypto#391) and updated the relevant code.
Fixes some WPT tests.