LibWeb: Align with parts of the Fetch specification steps#5771
Merged
AtkinsSJ merged 4 commits intoAug 8, 2025
Conversation
AtkinsSJ
requested changes
Aug 8, 2025
AtkinsSJ
left a comment
AtkinsSJ
left a comment
Member
There was a problem hiding this comment.
Thanks! Just a couple of nits.
This is an editoral change from the fetch spec. Since we already defined
the stream before it being used this only re-numbers the spec steps.
It also corrects a minor typo ('followings' to 'following') which was
corrected in the same editoral spec change.
User prompts are not tied to specific Windows or the client's Window. They are tied to a traversable navigable (browser tab).
kennethmyhra
force-pushed
the
sync-some-fetch-spec-changes
branch
from
August 8, 2025 09:04
d0a559b to
431b0f9
Compare
kennethmyhra
force-pushed
the
sync-some-fetch-spec-changes
branch
from
August 8, 2025 09:06
431b0f9 to
169228e
Compare
Contributor
Author
|
Thanks, Sam, and done! |
AtkinsSJ
approved these changes
Aug 8, 2025
AtkinsSJ
enabled auto-merge (rebase)
August 8, 2025 09:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pulls in a few changes from the Fetch spec:
LibWeb: Define stream variable before using it:
LibWeb: Replace request's "window" with "traversable for user prompts"
LibWeb: Implement AO populate request from client
LibWeb: Align Fetching chapter's "To fetch" with latest spec changes