-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
LibWeb: Add HTMLSelectedContentElement for customizable select #7024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LibWeb: Add HTMLSelectedContentElement for customizable select #7024
Conversation
b68c861 to
87e7de0
Compare
|
Your pull request has conflicts that need to be resolved before it can be reviewed and merged. Make sure to rebase your branch on top of the latest |
|
Your pull request has conflicts that need to be resolved before it can be reviewed and merged. Make sure to rebase your branch on top of the latest |
87e7de0 to
6865ca9
Compare
46d9940 to
378519d
Compare
378519d to
4a184a0
Compare
- Rename HTMLOptionElement's `owner_select_element()` to `nearest_select_element()` to better match spec terminology. - Update HTMLSelectElement's option list related algorithms. This change is part of the customizable <select> spec work. See whatwg/html#10548.
Introduce the HTMLSelectedContentElement and integrate it into <select>, <option> and HTMLParser. See whatwg/html#10548. There are two bugs with WPT tests which causes the third subtest in selectedcontent.html and selectedcontent-mutations.html fail. See whatwg/html#11882, web-platform-tests/wpt#55849.
4a184a0 to
7c9f456
Compare
AtkinsSJ
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Part of customizable select spec change sync work.
<select>options handling with latest spec changes.See whatwg/html#10548.