LibWeb/SVG: Implement activation behavior for SVGAElement
#7445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These could all be implemented in terms of `hyperlink_element_utils_element()`.
tcl3
force-pushed
the
libweb_svg_a_element_activation_behavior
branch
from
0ee6b21 to
8382efa
Compare
Previously we were using the IDL attribute value, which didn't follow the specification.
This allows us to use these methods from `SVGAElement` without inheriting `HTMLHyperlinkElementUtils`, which we can't do for `SVGAElement` due to a naming conflict with the `href()` method in `SVGURIReferenceMixin`.
tcl3
force-pushed
the
libweb_svg_a_element_activation_behavior
branch
from
8382efa to
a0980bb
Compare
This makes navigation work when clicking on SVG `<a>` elements.
tcl3
force-pushed
the
libweb_svg_a_element_activation_behavior
branch
from
a0980bb to
8e0ecb0
Compare
This aligns step 2 of `get_an_elements_target()` with the specification.
Member
Author
|
Closes #6781. I wasn't aware of this issue until now 😅. |
Member
|
Probably we will end up moving things around again if whatwg/html#12066 completes 😅 |
shannonbooth
approved these changes
Jan 12, 2026
gmta
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes navigation work when clicking on SVG
<a>elements.I had to move
follow_the_hyperlink()and other hyperlink navigation logic from HTMLHyperlinkElementUtils toDOM::Elementso that it could be shared byHTMLAnchorElementandSVGAElement.SVGAElementis supposed to implementHTMLHyperlinkElementUtilsbut can't as it stands because bothHTMLHyperlinkElementUtilsandSVGURIReferencehave ahref()method that causes a naming conflict. See w3c/svgwg#312 for further details.We also gain ~300 WPT subtests in the
referrer-policydirectory.Closes: #6781