LibWeb+LibWebView: Some cookie-related busy work #7673
+292
−320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgret-dev
reviewed
Jan 29, 2026
Rather than splitting this between Cookie and ParsedCookie, let's just put them all in Cookie. This just makes it more obvious where to put an upcoming helper.
The code here is much older than our IPv6 address support. We should be excluding these from cookie domain matches.
These seem to largely be editorial changes. See: https://author-tools.ietf.org/iddiff?url1=draft-ietf-httpbis-rfc6265bis-15&url2=draft-ietf-httpbis-rfc6265bis-22&difftype=--html I've also updated the spec links to use the "datatracker.ietf.org" URL rather than the "www.ietf.org" URL as the former has better dark-mode support and more handy sidebar links.
This had a single caller who did nothing but invoke it.
These were repeated in the CookieStore, and will be needed again for an upcoming feature.
trflynn89
force-pushed
the
cookie_updates
branch
from
73943ad to
1376fe5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does a bit of cleanup, and updates our cookie implementation to the latest RFC draft.