LibWeb: Use themed text selection colors#9704
Merged
Merged
Conversation
awesomekling
force-pushed
the
select-color
branch
3 times, most recently
from
May 29, 2026 09:29
9880af8 to
dc4f3a3
Compare
Look for screenshot expectations in an expected-<platform> directory before using the shared expected directory. This lets tests that cover system-derived rendering keep platform-specific baselines without making other platforms use the same PNG.
Use the page palette for default selection backgrounds instead of a hardcoded blue color. Tint opaque selection backgrounds before painting. Selected images stay visible through the overlay. Use SelectionText for default selected text and HighlightText. Authored ::selection colors still take precedence. On macOS, use a light translucent color matching other engines. Update selection and system-color baselines for the themed colors. Add macOS-specific screenshot baselines for tests whose expectations depend on system colors.
awesomekling
force-pushed
the
select-color
branch
from
May 29, 2026 09:31
dc4f3a3 to
f3af8f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve default selection backgrounds from the page palette instead of a hardcoded blue color. Tint opaque selection backgrounds before painting. This keeps selected images visible through the selection overlay.
Use the platform SelectionText role for default selected text and HighlightText. Authored ::selection colors still take precedence.
Update selection and system-color baselines for the themed colors.
Before:
After:
After (other color):
