Skip to content

Conversation

@MoriyaShiine
Copy link
Contributor

No description provided.

Copy link
Member

@Pyrofab Pyrofab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just need to fix the actions (I think a run of updateLicenseHeaders should do)

import java.util.List;
import java.util.Map;
import java.util.Set;
import java.util.*;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm partial to standardize on avoiding star imports, could you configure your formatter to avoid them in this codebase ?

Comment on lines 23 to 25
with:
fetch-depth: 0
filter: 'blob:none'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is what broke the workflow, the license task needs a git history to work

@Pyrofab Pyrofab merged commit b75dc01 into Ladysnake:1.21 Sep 8, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants