Added support for a working custom network connection with extension wallet #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapps of custom networks are stored with their networkType names hence find the network by txInfo.networkType
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extension wallet is built to support other networks other than Lamden networks but it cannot properly find custom user network to interact with, hence I added these changes.
This I feel is important in the case where developers have to run servers locally for active development and testing without having to depend on tesnet or mainnet. Developers should be able to have the same wallet experience as they would with the tesnet or mainnet.
I made just two changes in two files: networkController.js and masterController.js . They are minimal changes but work as they should when sending a transaction.