[search] Improve request logging with requester and counts - #11425
Open
nullpacket wants to merge 1 commit into
Open
nullpacket wants to merge 1 commit into
nullpacket wants to merge 1 commit into
Conversation
As per LandSandBoat#2072, several search handlers had cryptic or sparse logs. The shared request line now includes the requester (by source IP as a bracketed list). The search-comment, group-list, AH, and AH-history handlers now log their parameters and result counts in a consistent format. AH_REQUEST_MORE pagination is gated out of the per-request logs to avoid flooding, and a redundant category-lookup log was removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Closes #2072. Search-server request logging was sparse and inconsistent. Some handlers were lacking in logging while others were cryptic and noisy.
Steps to test these changes