[lua] Blue magic: Fixup magic bursting - #11533
Open
WinterSolstice8 wants to merge 1 commit into
Open
WinterSolstice8 wants to merge 1 commit into
WinterSolstice8 wants to merge 1 commit into
Conversation
Xaver-DaRed
reviewed
Sep 19, 2026
| if skillchainCount > 0 then | ||
| finalDamage = math.floor(finalDamage * xi.spells.damage.calculateIfMagicBurst(caster, target, spellElement, skillchainCount)) | ||
| finalDamage = math.floor(finalDamage * xi.spells.damage.calculateIfMagicBurstBonus(caster, target, spellId, skillType, spellElement)) | ||
| if canMB and skillchainCount > 0 then |
Contributor
There was a problem hiding this comment.
you already use canMB to default skillchainCount to 0. skillchainCount cant ever be > 0 without canMB being true, making its check here redundant, no?
WinterSolstice8
force-pushed
the
blu_stuff
branch
from
September 19, 2026 12:20
8457d71 to
320e812
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Fixes up magic bursting. I might have accidentally broke some of this doing the massive skill conversion for Enfeeble/Drain/Breath because they don't get the massive default params like standard magical and physical spells.
Additionally, it looks like we were applying the MB bonus to magic accuracy even if Burst Affinity was not up in all cases.
Steps to test these changes
Magic Burst with blue magic and see it work. In particular, MP/HP drains, breaths, enfeebles. Enfeebles will present only as a messaging change (but macc bonus is fed through the appropriate channels as well.)