Skip to content

[2.1] provide credentials from attestation, even if server doesn't return them#43

Merged
DarkGhostHunter merged 3 commits intoLaragear:2.xfrom
miken32:2.x
Mar 13, 2026
Merged

[2.1] provide credentials from attestation, even if server doesn't return them#43
DarkGhostHunter merged 3 commits intoLaragear:2.xfrom
miken32:2.x

Conversation

@miken32
Copy link
Copy Markdown
Contributor

@miken32 miken32 commented Mar 10, 2026

Description

As discussed in #41, the attestation returns a mostly empty result if the server response is empty. Short of re-implementing the function yourself there's no way to get the credentials. This provides the credentials as a return, if the server response is empty.

@DarkGhostHunter
Copy link
Copy Markdown
Collaborator

I believe you will need to write tests for that line, and update the README so everyone knows.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (d7d8f2a) to head (ceced6f).
⚠️ Report is 6 commits behind head on 2.x.

Additional details and impacted files
@@            Coverage Diff            @@
##               2.x       #43   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          172       172           
  Branches        50        51    +1     
=========================================
  Hits           172       172           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

also fixed up numerous references to `credential` instead of `credentials`
@sonarqubecloud
Copy link
Copy Markdown

@DarkGhostHunter DarkGhostHunter merged commit e120576 into Laragear:2.x Mar 13, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants