Fixes stiky header "bumping" in datatables #5880
Merged
+284
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As me and @tabacitu previously noticed (Laravel-Backpack/community-forum#1410), Datatable components in the middle of the page (not viewable on the view port at the top of the page), had some "bumps" when trying to scroll past them, making it difficult to go past by a table in the middle of the page due to sticky header tables.
That's due to how datatable plugin works given the scroll position.
We manually calculate the sticky behaviour so we ensure it always works as expected. In addition we also added an option that allow to disable the sticky header completely in case you didn't wanted it.