Conversation
|
|
|
Yeah, I fixed that. There was a merge conflict I accidentally merged (I thought it was just cosmetic updates and didn't do full review on last commits) This works now on d801801 However, the last commit (9ab10f8) fails. I think this dies on aggregator validation that queries the contract with the signer key, expecting it to be operator key. interface IECDSAStakeRegistry {
/*
* @notice Retrieves the latest signing key for a given operator.
* @param operator The address of the operator.
* @return The latest signing key of the operator.
*/
function getLatestOperatorSigningKey(
address operator
) external view returns (address);
/*
* @notice Retrieves the signing key for an operator at a specific block.
* @param operator The address of the operator.
* @param blockNumber The block number to query at.
* @return The signing key of the operator at the given block.
*/
function getOperatorSigningKeyAtBlock(
address operator,
uint256 blockNumber
) external view returns (address);
/*
* @notice Retrieves the latest operator address associated with a signing key.
* @param signingKey The address of the signing key.
* @return The latest operator address associated with the signing key, or address(0) if none.
*/
function getLatestOperatorForSigningKey(
address signingKey
) external view returns (address);
/*
* @notice Retrieves the operator address associated with a signing key at a specific block.
* @param signingKey The address of the signing key.
* @param blockNumber The block number to query at.
* @return The operator address associated with the signing key at the given block, or address(0) if none.
*/
function getOperatorForSigningKeyAtBlock(
address signingKey,
uint256 blockNumber
) external view returns (address);
} |
|
I just updated to the latest changes on wavs-middleware and this passes now! |
| DELEGATION=0.001ether AVS_PRIVATE_KEY=${AVS_PRIVATE_KEY} make V=1 operator-register | ||
| DELEGATION=0.001ether OPERATOR_PRIVATE_KEY=${OPERATOR_PRIVATE_KEY} AVS_SIGNING_ADDRESS=${AVS_SIGNING_ADDRESS} make V=1 operator-register |
10c6190 to
2d38069
Compare
reecepbcups
left a comment
There was a problem hiding this comment.
Nice! Glad we get multiple service keys in ECDSA now :D -- ran though it, all works looks good.
I am trying to update to the latest wavs-middleware (merged today) that takes separate operator key an avs address.
First setting them both to the same path to make sure I can run through the README and the syntax is correct everywhere. But I am hitting some issues I would love @reecepbcups to help debug.
Once that is working, I would set the keys to be different and see if wavs handles this properly (or better, whether the new contracts handle this properly)