test: redistribution upgrade #1410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ypatil12
force-pushed
the
feat/redistibution-upgrade-test
branch
from
02658c6 to
452537c
Compare
ypatil12
changed the title
ypatil12
force-pushed
the
feat/redistibution-upgrade-test
branch
from
452537c to
9ba5f3d
Compare
ypatil12
commented
May 27, 2025
| @@ -462,44 +462,6 @@ contract SlashEscrowFactoryUnitTests_setStrategyEscrowDelay is SlashEscrowFactor | |||
| } | |||
| } | |||
|
|
|||
| contract SlashEscrowFactoryUnitTests_getBurnOrRedistributionDelay is SlashEscrowFactoryUnitTests { | |||
There was a problem hiding this comment.
Redundant test: SlashEscrowFactoryUnitTests_getEscrowDelay
ypatil12
changed the title
ypatil12
force-pushed
the
feat/redistibution-upgrade-test
branch
from
d0ae1e7 to
ba469b5
Compare
0xClandestine
force-pushed
the
release-dev/redistribution
branch
from
7e82d53 to
d88ee4f
Compare
ypatil12
force-pushed
the
feat/redistibution-upgrade-test
branch
from
ba469b5 to
a88a807
Compare
test: increase burnable shares chore: add tests feat: simplify escrow delay chore: format chore: clarify natspec chore: fix typos feat: add convenience view functions (#1407) chore: remove commented code chore: format chore: format chore: add regression chore: naming chore: naming fix: build fix: slaky test chore: format chore: push chore: push test: passing redistribution upgrade test
ypatil12
force-pushed
the
feat/redistibution-upgrade-test
branch
from
a88a807 to
15a2bce
Compare
| * @dev The interface remains the exact same, except `SlashOperator` does not return the slashID or shares | ||
| * @dev This interface is the minimal possibl interface needed for the redistribution upgrade test | ||
| */ | ||
| interface IAllocationManager_PreRedistribution { |
There was a problem hiding this comment.
Is this needed given only return values were changed?
There was a problem hiding this comment.
Main issue lies with existing return values changing, since contracts calling wold attempt to copy returndata that doesn't exist or is misplaced.
There was a problem hiding this comment.
I would assume it's not needed, but for some reason I'm reverting...
0xClandestine
approved these changes
May 30, 2025
0xClandestine
pushed a commit
that referenced
this pull request
May 30, 2025
**Motivation:** We need to sanity test that slashes completed prior to redistribution can be burned after redistribution. **Modifications:** - Add redistribution upgrade test which tests: 1. A slash prior to redistribution can have its shares burned after the upgrade 2. A slash prior to redistribution can have its shares burned prior to upgrade & storage is cleared - Remove all User_m2/m1 functionality **Result:** Basic upgrade test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We need to sanity test that slashes completed prior to redistribution can be burned after redistribution.
Modifications:
Result:
Basic upgrade test.