test: redistribution integration #1415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xClandestine
changed the title
0xClandestine
commented
May 28, 2025
Comment on lines
-467
to
+469
| shares[i] = burnOrRedistributableShares.get(keys[i]); | ||
| (, shares[i]) = burnOrRedistributableShares.tryGet(keys[i]); |
There was a problem hiding this comment.
There was a small bug present with the getBurnOrRedistributableShares getters. EnumerableMap.get() reverts if a key does not exist.
ypatil12
reviewed
May 29, 2025
src/test/integration/tests/Deposit_Delegate_Allocate_Slash_Escrow.t.sol
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| function testFuzz_fullSlash_EscrowTiming_RightAfterPasses(uint24 _random) public rand(_random) { | ||
| // 6) Operator is full slashed. |
There was a problem hiding this comment.
Can we do random? Also, this can be in the init step since you do it for all of these tests
There was a problem hiding this comment.
Ah I see why you're slashing full -> to not have to re-calculate the amount they would get out? I guess we can add in a separate PR to not block this
There was a problem hiding this comment.
could maybe do a slash half
There was a problem hiding this comment.
You can still do random if get_slashing_rand returns the shares out
There was a problem hiding this comment.
will improve in next pr
src/test/integration/tests/Deposit_Delegate_Allocate_Slash_Escrow.t.sol
Outdated
Show resolved
Hide resolved
src/test/integration/tests/Deposit_Delegate_Allocate_Slash_Escrow.t.sol
Outdated
Show resolved
Hide resolved
src/test/integration/tests/Deposit_Delegate_Allocate_Slash_Escrow.t.sol
Outdated
Show resolved
Hide resolved
0xClandestine
force-pushed
the
test/integration
branch
from
8296fb8 to
64443eb
Compare
0xClandestine
merged commit cb68310
into
release-dev/redistribution
10 of 11 checks passed
0xClandestine
added a commit
that referenced
this pull request
May 30, 2025
**Motivation:** We want integration test coverage for the redistribution relaese. **Modifications:** - Fixed view revert bug (see comment bellow). - Added timing tests (cannot release escrow before delay, can after) **Result:** Integration test coverage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We want integration test coverage for the redistribution relaese.
Modifications:
Result:
Integration test coverage.