Skip to content

Comments

test: integration with slashingRegistryCoordinator#388

Merged
stevennevins merged 14 commits intotest/slashing-releasefrom
test/integration-slashing-registry
Feb 12, 2025
Merged

test: integration with slashingRegistryCoordinator#388
stevennevins merged 14 commits intotest/slashing-releasefrom
test/integration-slashing-registry

Conversation

@8sunyuan
Copy link
Collaborator

@8sunyuan 8sunyuan commented Feb 7, 2025

Edge case fixed:
The AllocationManager has a try/catch in the deregisterFromOperatorSets implementation. This was put in place to allow operators to force deregister from an AVS. However this can lead to a weird state where an operator is registered in AVS contracts but deregistered from EigenLayer. Checks for this are added for forceDeregistration by the AVS to avoid reverts. In addition, AVSSync (updateOperatorsForQuorum, updateOperator) will now also include these operators to be force deregistered.

Refactored integration tests to only use the SlashingRegistryCoordinator and defines a OperatorSetUser contract.
The SlashingRegistryCoordinator and the Registry contracts do not depend on the ServiceManager base contract.
Interactions with the core protocol are integrated with UAM and setting the avsAccountIdentifier as the unique account identifier address for the AVS. For existing AVSs, this will be the address of your ServiceManager contract.

TODOs, could be implemented in followup PR

  1. integration tests with the RegistryCoordinator and legacy quorums will require some fork integration testing refactor and testing the legacy interfaces. This is still a TODO that should be added.
  2. Integration tests with slashing and allocations
    • Should test the following, allocate, register to AVS after meeting slashable stake threshold, slash operator, update stakes, expect operator to have been force deregistered
    • allocate, register to AVS meeting slashable stake threshold, create vetoeable slashing request, veto slash, expect operator magnitude and shares to be unchanged

Copy link
Member

@0xClandestine 0xClandestine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits, looks good otherwise.

@8sunyuan 8sunyuan force-pushed the test/integration-slashing-registry branch from d017065 to fe5c9dc Compare February 12, 2025 15:33
@stevennevins stevennevins merged commit e8a6608 into test/slashing-release Feb 12, 2025
5 checks passed
@stevennevins stevennevins deleted the test/integration-slashing-registry branch February 12, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants