Skip to content

Comments

fix: avs registrar interface#398

Closed
8sunyuan wants to merge 2 commits intotest/slashing-releasefrom
fix/avs-registrar-interface
Closed

fix: avs registrar interface#398
8sunyuan wants to merge 2 commits intotest/slashing-releasefrom
fix/avs-registrar-interface

Conversation

@8sunyuan
Copy link
Collaborator

Updated eigenlayer-contracts submodule commit based on breaking interface change here Layr-Labs/eigenlayer-contracts#1085.

Added avs require checks in registerOperator, deregisterOperator and fixed other affected interfaces.

@0xClandestine 0xClandestine self-requested a review February 12, 2025 15:30
Copy link
Member

@0xClandestine 0xClandestine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

uint32[] memory operatorSetIds,
bytes calldata data
) external override onlyAllocationManager onlyWhenNotPaused(PAUSED_REGISTER_OPERATOR) {
require(avs == accountIdentifier, InvalidAVS());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accountIdentifier name could be improved..

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

avsIdentifier?

@8sunyuan 8sunyuan marked this pull request as draft February 13, 2025 16:52
@stevennevins
Copy link
Contributor

duplicate of #399

@stevennevins stevennevins deleted the fix/avs-registrar-interface branch March 31, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants