Skip to content

Introduce automatic recognition of internal or external links to the menu setting - #123

Open
Tenktau wants to merge 1 commit into
LeNPaul:gh-pagesfrom
Tenktau:gh-pages
Open

Introduce automatic recognition of internal or external links to the menu setting#123
Tenktau wants to merge 1 commit into
LeNPaul:gh-pagesfrom
Tenktau:gh-pages

Conversation

@Tenktau

@Tenktau Tenktau commented Jun 13, 2025

Copy link
Copy Markdown

Why Submit this change?

Take myself as an example. When I want a certain item in the menu to directly redirect to another site of mine, I encounter an error because this statement (<a href="{{ site.github.url }}/{{ item.url }}">{{ item.name }}</a>) causes my external link to be embedded behind the link of this site ({{ site.github.url }}).

How this change work?

Just a simple judgment statement was added to determine whether it meets the requirement of containing a specific string, thereby adjusting the redirection statement.

What will this change bring?

Users can directly jump to the external link (or send an email) they want by clicking the menu.


The schematic code is as follows:

menu:
- {name: 'About', url: 'about.html'} # Visit the about page within the site
- {name: 'GitHub', url: 'https://github.com/'} # Redirect to the external link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant