Skip to content

[live-demo] Plugin styles should be more specific than default styles (defined in style/partials/code.css) #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DmitrySharabin
Copy link
Collaborator

@DmitrySharabin DmitrySharabin commented Feb 13, 2025

This PR addresses the issue of low text contrast on live demo slides (when projecting them). Turns out it's a specificity issue: text color should be canvas

instead of the inherited one
color: inherit;

Before

image

After

image

Copy link

netlify bot commented Feb 13, 2025

Deploy Preview for inspirejs ready!

Name Link
🔨 Latest commit bd12f7a
🔍 Latest deploy log https://app.netlify.com/sites/inspirejs/deploys/67adf2657a15110008771791
😎 Deploy Preview https://deploy-preview-170--inspirejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Owner

@LeaVerou LeaVerou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the :where() was intentional, so that host code can override it easily. I'm not sure removing it is the right fix, perhaps the right fix is to reduce the overeager specificity of whatever was overriding it.

@DmitrySharabin
Copy link
Collaborator Author

I think the :where() was intentional, so that host code can override it easily. I'm not sure removing it is the right fix, perhaps the right fix is to reduce the overeager specificity of whatever was overriding it.

Will try. Thanks!

@LeaVerou
Copy link
Owner

LeaVerou commented Feb 14, 2025

Also, even wrt the issue of the live demo styling, that is not a correct fix. Check out the lecture videos for what is should look like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants