Feat/symbol - #551
Merged
Merged
Conversation
…exported from src/index.ts
…exported from src/index.ts
…exported from src/index.ts
…exported from src/index.ts
…exported from src/index.ts
…exported from src/index.ts
…exported from src/index.ts
…ule must throw VeriTixError not raw Error
…ule must throw VeriTixError not raw Error
…ule must throw VeriTixError not raw Error
…ule must throw VeriTixError not raw Error
…ule must throw VeriTixError not raw Error
…ule must throw VeriTixError not raw Error
…ule must throw VeriTixError not raw Error
…ule must throw VeriTixError not raw Error
…ule must throw VeriTixError not raw Error
|
@nafiuishaaq Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Summary of Changes
1. Updated src/index.ts to export all missing symbols from the codebase:
VeriTixClientExtended,createSafeToJSON,createSafeInspect,VeriTixSDK, andcreateFromFreighterBatchSettlementResultfrom src/types/index.tsEventsService,EventDashboard,EventGalleryService,RevenueAnalyticsModule,TicketAnalyticsModule,CollaboratorModule,TicketPurchaseModuleTRANSACTION_CHARGE_RATEandMAX_COLLABORATORS_PER_EVENT2. Fixed src/modules/freighter-factory.ts: Added missing import for VeriTixClient which was causing a compilation error.
3. Fixed src/client.ts: Changed
keypairfrom private to protected to allow access from the extended VeriTixClientExtended class in client-extended.ts, which fixes the TypeScript access modifier error.All exported symbols in the src/ directory are now properly exported from the root src/index.ts, so consumers importing from @veritix/contract-sdk can access all of them! The TypeScript compiler will now pass without errors, confirming there are no orphaned types.
closes #502
Summary of Changes
1. Updated src/utils/errors.ts to add new error codes for all missing cases:
NotImplementedfor unimplemented methodsCollaboratorNotFound,CollaboratorAlreadyExists,MaxCollaboratorsReachedfor collaborator module errorsFreighterNotFoundfor freighter factory errorsClientNotConnectedfor errors when client isn't connected before useInvalidInputfor all input/parsing/scval conversion errors2. Fixed all raw throw new Error instances across src/modules and src/utils:
All errors in the codebase now use VeriTixError with an appropriate error code, allowing consumers to use type-safe error branching! The SDK's error handling system is now fully consistent.
Checklist
npm run buildpassesnpm testpassesnpm run lintpasses