Add split_to_escrow tests, contract_paused_for, get_all_escrows_between, and cancel_recurring_batch tests - #782
Merged
BigBen-7 merged 1 commit intoAug 28, 2026
Conversation
zakariyaufarida5-wq
force-pushed
the
zakariyaufarida5-wq/issues-746-739-738-737
branch
from
August 27, 2026 23:30
ad9a42b to
a3a17eb
Compare
|
@zakariyaufarida5-wq Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
zakariyaufarida5-wq
force-pushed
the
zakariyaufarida5-wq/issues-746-739-738-737
branch
from
August 27, 2026 23:41
a3a17eb to
f26cbdf
Compare
Collaborator
|
@zakariyaufarida5-wq please resolve conflicts |
zakariyaufarida5-wq
force-pushed
the
zakariyaufarida5-wq/issues-746-739-738-737
branch
2 times, most recently
from
August 28, 2026 13:22
777c95b to
b5331a0
Compare
…en, and cancel_recurring_batch tests - Add contract_paused_for view returning ledgers elapsed since the contract was paused (Lead-Studios#739) - Add get_all_escrows_between view returning all escrow IDs between a depositor and beneficiary (Lead-Studios#738) - Add split_to_escrow test coverage (Lead-Studios#746) - Add cancel_recurring_batch test coverage (Lead-Studios#737) - Repair pre-existing upstream merge damage (duplicate VeritixContract blocks, mid-file use statements) so the crate compiles
Contributor
Author
|
conflict resolved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements four requested tickets as simple, focused additions:
contract_paused_for— a new view returning how many ledgers the contract has been continuously paused for (Nonewhen not paused).get_all_escrows_between— a new view returning all escrow ids (active and settled) between a depositor and beneficiary.Fixes:
Closes #746
Closes #739
Closes #738
Closes #737