chore(iac/aws/networking): remove redundant Secrets Manager VPC endpoint

terraform/modules/networking/aws/main.tf

@@ -1,6 +1,7 @@
 # AWS VPC Module with IPv6
-# Creates VPC with IPv6 support - no NAT Gateway or VPC Endpoints needed
-# Cost savings: ~$54/month (NAT Gateway + VPC Endpoints eliminated)
+# Creates VPC with IPv6 support. NAT (fck-nat) handles egress for ECR pulls
+# and any AWS APIs that lack IPv6, so we no longer need per-service VPC
+# interface endpoints.
 # Supports: new VPC, existing VPC, or default VPC
 
 terraform {
@@ -405,6 +406,13 @@ resource "aws_subnet" "private" {
     Name = "${var.stack_name}-private-${data.aws_availability_zones.available.names[count.index]}"
     Type = "private"
   })
+
+  lifecycle {
+    precondition {
+      condition     = var.enable_nat_gateway
+      error_message = "enable_nat_gateway must be true when creating private subnets: without it, module-created private subnets have no IPv4 path to AWS services (Secrets Manager, ECR, etc.). Enable the fck-nat instance or use an existing VPC with its own egress."
+    }
+  }
 }
 
 # ==============================================
@@ -683,75 +691,3 @@ resource "aws_iam_role_policy" "flow_logs" {
     ]
   })
 }
-
-# ==============================================
-# VPC Endpoints (for services without IPv6 support)
-# ==============================================
-
-# Security group for VPC endpoints
-resource "aws_security_group" "vpc_endpoints" {
-  name_prefix = "${var.stack_name}-vpc-endpoints-"
-  description = "Security group for VPC endpoints"
-  vpc_id      = local.vpc_id
-
-  # HTTPS from VPC (IPv4)
-  ingress {
-    description = "HTTPS from VPC (IPv4)"
-    from_port   = 443
-    to_port     = 443
-    protocol    = "tcp"
-    cidr_blocks = [local.vpc_cidr]
-  }
-
-  # HTTPS from VPC (IPv6)
-  ingress {
-    description      = "HTTPS from VPC (IPv6)"
-    from_port        = 443
-    to_port          = 443
-    protocol         = "tcp"
-    ipv6_cidr_blocks = var.enable_ipv6 ? [local.vpc_ipv6_cidr] : []
-  }
-
-  # Allow all outbound (IPv4)
-  egress {
-    description = "Allow all outbound (IPv4)"
-    from_port   = 0
-    to_port     = 0
-    protocol    = "-1"
-    cidr_blocks = ["0.0.0.0/0"]
-  }
-
-  # Allow all outbound (IPv6)
-  egress {
-    description      = "Allow all outbound (IPv6)"
-    from_port        = 0
-    to_port          = 0
-    protocol         = "-1"
-    ipv6_cidr_blocks = ["::/0"]
-  }
-
-  tags = merge(var.tags, {
-    Name = "${var.stack_name}-vpc-endpoints-sg"
-  })
-
-  lifecycle {
-    create_before_destroy = true
-  }
-}
-
-# Secrets Manager VPC Endpoint (required - no IPv6 support)
-resource "aws_vpc_endpoint" "secretsmanager" {
-  vpc_id              = local.vpc_id
-  service_name        = "com.amazonaws.${data.aws_region.current.name}.secretsmanager"
-  vpc_endpoint_type   = "Interface"
-  subnet_ids          = local.private_subnet_ids
-  security_group_ids  = [aws_security_group.vpc_endpoints.id]
-  private_dns_enabled = true
-
-  tags = merge(var.tags, {
-    Name = "${var.stack_name}-secretsmanager-endpoint"
-  })
-}
-
-# Data source for current region
-data "aws_region" "current" {}

terraform/modules/networking/aws/outputs.tf

@@ -98,19 +98,3 @@ output "database_vpc_config" {
     security_group_id     = aws_security_group.database.id
   }
 }
-
-# VPC Endpoints
-output "vpc_endpoints_security_group_id" {
-  description = "Security group ID for VPC endpoints"
-  value       = aws_security_group.vpc_endpoints.id
-}
-
-output "secretsmanager_endpoint_id" {
-  description = "Secrets Manager VPC endpoint ID"
-  value       = aws_vpc_endpoint.secretsmanager.id
-}
-
-output "secretsmanager_endpoint_dns" {
-  description = "Secrets Manager VPC endpoint DNS names"
-  value       = aws_vpc_endpoint.secretsmanager.dns_entry
-}