Remove code using a deprecated method #120
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `getRegisters()` method of `SDT` has been marked deprecated for a long time, but has been kept in the code base as it is used in various tests. This commit makes the method private and removes (unused) code in other classes that was calling this method. This change shuts off two deprecation warnings from the linter.
kostis
force-pushed
the
remove-deprecated-getRegisters
branch
from
7ae0337 to
0e923d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
getRegisters()method ofSDThas been marked deprecated for along time, but has been kept in the code base as it is used in various
tests. This commit makes the method private and removes (unused) code
in other classes that was calling this method.
This change shuts off two deprecation warnings from the linter.