Conversation
|
A few little remarqs here:
This filtering tool will be awesome to release! |
Nice catch!
Fair enough!
OK. When a filter is applied, the button becomes "Clear filter". Do we keep it that way or do you have something else in mind? Thanks for the feedback, I will rebase the branch and make the modifications 🙏 |
|
We can keep "Clear filter" I believe. |
e7dfd37 to
dafb7a1
Compare
|
Fixed everything and disabled Cauer and Bessel filters as they're not yet implemented (https://github.com/qsib-cbie/sci-rs/blob/d0a35b49ca7c304c3cf2ff7e19255ec673d63df0/sci-rs/src/signal/filter/design/iirfilter.rs#L116-L126). However, when working from my fork I had the latest commit of sci-rs but their latest crate version is |
dfd3ef7 to
a53fbde
Compare
This PR adds the following changes:
There is still one issue to address. The code is depending on qsib-cbie/sci-rs#80
We may need to wait for this PR to be closed in order to use the official sci-rs repository instead of my fork.